Remove 21 dead functions detected by deadcode analysis#71
Open
Remove 21 dead functions detected by deadcode analysis#71
Conversation
Remove functions/methods confirmed unreachable even from test code by golang.org/x/tools/cmd/deadcode analysis: - analysis: LoadLatest, LoadAll - logging: Logger.With, Logger.Err, Logger.Event - orchestrator: WithBudget, WithQueue (+ queue field cleanup) - scheduler: Scheduler.Schedule - security: AuditLogger.RotateIfNeeded, CredentialManager.GetWarnings, CredentialManager.EnsureNoCredentialsInFile, Sandbox.ExecuteWithIO, Manager.Credentials, Manager.Audit, Manager.CheckPreExecution - snapshots: Collector.GetSinceWeekStart, Collector.GetHourlyAverages - tasks: Selector.ClearSimulatedCooldowns, Queue type + NewQueue/Add/Next - tmux: WithWorkDir Nightshift-Task: dead-code Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deadcode -test ./...Changes by package
analysisLoadLatest,LoadAllloggingLogger.With,Logger.Err,Logger.EventorchestratorWithBudget,WithQueue+queuefield cleanupschedulerScheduler.SchedulesecurityAuditLogger.RotateIfNeeded,CredentialManager.GetWarnings,CredentialManager.EnsureNoCredentialsInFile,Sandbox.ExecuteWithIO,Manager.Credentials,Manager.Audit,Manager.CheckPreExecutionsnapshotsCollector.GetSinceWeekStart,Collector.GetHourlyAveragestasksSelector.ClearSimulatedCooldowns,Queuetype +NewQueue/Add/NexttmuxWithWorkDirTest plan
go build ./...passesgo test ./...passes (all packages)Nightshift-Task: dead-code
Nightshift-Ref: https://github.com/marcus/nightshift
Automated by nightshift