Open
Conversation
- Propagate LastInsertId error in snapshot collector instead of silently producing ID=0 - Use http.Client with 30s timeout for Slack webhooks instead of default client that can hang indefinitely - Use filepath.Join for .git path in RepositoryExists for correct cross-platform handling - Check filepath.Abs errors in glob pattern expansion instead of silently using empty strings that break exclude-set matching - Return error from ValidateProjectPath when os.UserHomeDir fails, preventing home-directory security check from being silently skipped Nightshift-Task: bug-finder Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LastInsertId()error instead of discarding it with_, which silently produces ID=0http.Post(no timeout) withhttp.Client{Timeout: 30s}to prevent indefinite hangsfilepath.Joininstead of string concatenation for.gitpath inRepositoryExistsfilepath.Abserrors in glob expansion instead of silently using empty stringsValidateProjectPathwhenos.UserHomeDir()fails, preventing home-directory block from being silently skippedTest plan
go build ./...passesgo vet ./...passessnapshots,reporting,analysis,projects,security)Nightshift-Task: bug-finder
Nightshift-Ref: https://github.com/marcus/nightshift
🤖 Generated with Claude Code
Automated by nightshift