Implement Lua #45
Draft
Implement Lua #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFI gonna go brrrr
See: LuaJIT/LuaJIT#1165 Added it just to be safe since we were thinking about possibly using it
[+] Mostly implemented CLuaInterface [+] Added lua_getuserdatatype [#] Updated to C++17
|
fyi, I think this is the right approach. LuaJIT really wants to stay native and in-process for hot paths. Keeping lua_State, GC, userdata, hooks, and math types in a small native core with a boring C ABI, and letting C# just orchestrate and call into it synchronously, feels like the cleanest and most Source-accurate way to do this. That keeps the bridge minimal and avoids turning FFI into a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ side should be somewhat implemented now, though I still suck at C# and before I make a mess it would probably be best to get some feedback of which functions for FFI to add and what the best way to bridge C# & C++ would be