Skip to content

Upgrade Dependencies to Newest Versions#2

Open
jscatena88 wants to merge 5 commits into
marcelbuesing:masterfrom
jscatena88:dep_updates
Open

Upgrade Dependencies to Newest Versions#2
jscatena88 wants to merge 5 commits into
marcelbuesing:masterfrom
jscatena88:dep_updates

Conversation

@jscatena88
Copy link
Copy Markdown

I took a crack at upgrading all dependencies to their newest versions. I have not yet tested this on real hardware with real DBC files, I'll try to get to that in the next few days and report back. In the meantime I figured I would throw this up for comment.

Copy link
Copy Markdown

@wallem89 wallem89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work done @jscatena88 ! I want to use this crate too but ran into the same issues. Some existing once but also some new clippy issues.
I have put them as comments on the existing and new code. Can you fix them?

I am also to get a hold of @marcelbuesing to discus maintenance of this crate because I would love to help out here!

Comment thread src/bin/candumprb.rs Outdated
Comment thread src/bin/candumprb.rs Outdated
Comment thread src/bin/candumprb.rs Outdated
Comment thread src/bin/candumprb.rs Outdated
Comment thread src/bin/cangenrb.rs Outdated
Comment thread src/bin/cangenrb.rs Outdated
Comment thread src/bin/cangenrb.rs Outdated
Comment thread src/candump_parser.rs Outdated
Comment thread src/candump_parser.rs Outdated
Comment thread src/candump_parser.rs Outdated
@jscatena88
Copy link
Copy Markdown
Author

Hey sorry for the delay, I had put this down and was busy with other stuff. I originally was just trying to make the absolute minimal changes possible since I assumed that'd make it easier to review or change. I also didn't want to be opinionated about someone elses work with respect to unused code. But if you are going to be taking over and are cool with it I'm more than happy to be a bit more aggressive.

I just went through and tackled all the clippy lints. I also temporarily toggled on clippy pedantic locally and refactored some as casts to hopefully be more robust (kind of odd that can_dbc uses u64 for signal size and offset...)

Also all the unused code in candump_parser.rs led me to realize that essentially nothing was in the lib.rs. It had those few structs that were public, but all functions were private. And the binaries weren't using anything from it. So I went ahead and jsut removed the library target, candump_parser.rs and lib.rs altogether.

But I know that is pretty aggressive so I'm open to push back on that. I got the vibe though that you are trying to really clean house

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants