MSF-16-SASS #28
Open
MSF-16-SASS #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc-leung
requested changes
Jun 1, 2019
| @@ -0,0 +1,246 @@ | |||
| @mixin box($width, $height) { | |||
| width: $width; | |||
| height: $height; | |||
Contributor
There was a problem hiding this comment.
what if I just wanna set width? can I still use this mixin?
kc-leung
requested changes
Jun 1, 2019
Contributor
There was a problem hiding this comment.
A lot of these mixins are just for cross-browser compatibility. That's not the reason I asked you to create the mixins. The point is to see which style are the same from every components and create a mixin for them so we can re-use them in different components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created mixins.scss. Added a bunch of stuff that might be helpful.
Fix #28