Skip to content

Remove dead code: unused functions, deprecated options, and unreachab…#815

Merged
caglarpir merged 1 commit intomainfrom
dead-code-cleanup
Mar 4, 2026
Merged

Remove dead code: unused functions, deprecated options, and unreachab…#815
caglarpir merged 1 commit intomainfrom
dead-code-cleanup

Conversation

@caglarpir
Copy link
Contributor

@caglarpir caglarpir commented Mar 3, 2026

…le code

  • Remove unused extract_camera_model() from gpmf_parser.py and blackvue_parser.py (superseded by extract_gopro_info() and extract_blackvue_info())
  • Remove dead rich logging code path in utils.py (unconditional raise ImportError made it unreachable)
  • Remove deprecated MAPMetaTags field from types.py, schema, and JSON schema (deprecated since v0.10.0, never set in production)
  • Remove commented-out ffmpeg options from ffmpeg.py
  • Update tests to reflect removed features

@meta-cla meta-cla bot added the cla signed label Mar 3, 2026
@caglarpir caglarpir force-pushed the dead-code-cleanup branch 2 times, most recently from ee9ee87 to 9305a95 Compare March 3, 2026 13:35
…e code

- Remove unused extract_camera_model() from blackvue_parser and gpmf_parser
- Remove deprecated MAPMetaTags field from ImageMetadata and schema
- Remove dead RichHandler import branch in utils
- Remove dead comments in ffmpeg.py
@caglarpir caglarpir force-pushed the dead-code-cleanup branch from 9305a95 to bdb7a67 Compare March 3, 2026 13:52
@caglarpir caglarpir merged commit 3f46754 into main Mar 4, 2026
16 checks passed
@caglarpir caglarpir deleted the dead-code-cleanup branch March 4, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant