Skip to content

Calculate video filesize when using gpx extractor #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptpt merged 1 commit into from
Aug 21, 2025
Merged

Calculate video filesize when using gpx extractor #775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mapillary_tools/geotag/video_extractors/gpx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
else:
from typing_extensions import override

from ... import exceptions, geo, telemetry, types
from ... import exceptions, geo, telemetry, types, utils
from ..utils import parse_gpx
from .base import BaseVideoExtractor
from .native import NativeVideoExtractor
Expand Down Expand Up @@ -59,6 +59,7 @@ def extract(self) -> types.VideoMetadata:
self._rebase_times(gpx_points)
return types.VideoMetadata(
filename=self.video_path,
filesize=utils.get_file_size(self.video_path),
filetype=types.FileType.VIDEO,
points=gpx_points,
)
Expand Down
1 change: 1 addition & 0 deletions tests/integration/test_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ def test_process_video_geotag_source_with_gpx_specified(setup_data: py.path.loca

assert len(descs) == 1
assert len(descs[0]["MAPGPSTrack"]) > 0
assert descs[0]["filesize"] == 2848208


def test_process_video_geotag_source_gpx_not_found(setup_data: py.path.local):
Expand Down
Loading