Skip to content

fix: progress bar was initialized twice #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptpt merged 1 commit into from
Jul 30, 2025
Merged

fix: progress bar was initialized twice #765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions mapillary_tools/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ def _setup_tdqm(emitter: uploader.EventEmitter) -> None:
upload_pbar: tqdm | None = None

@emitter.on("upload_start")
@emitter.on("upload_fetch_offset")
def upload_start(payload: uploader.Progress) -> None:
nonlocal upload_pbar

Expand All @@ -263,9 +262,22 @@ def upload_start(payload: uploader.Progress) -> None:
disable=LOG.getEffectiveLevel() <= logging.DEBUG,
)

@emitter.on("upload_fetch_offset")
def upload_fetch_offset(payload: uploader.Progress) -> None:
assert upload_pbar is not None, (
"progress_bar must be initialized in upload_start"
)
offset = payload.get("offset", 0)
if offset > 0:
upload_pbar.reset()
upload_pbar.update(offset)

@emitter.on("upload_progress")
def upload_progress(payload: uploader.Progress) -> None:
assert upload_pbar is not None, "progress_bar must be initialized"
assert upload_pbar is not None, (
"progress_bar must be initialized in upload_start"
)
upload_pbar.colour = "GREEN"
upload_pbar.update(payload["chunk_size"])

@emitter.on("upload_end")
Expand Down
Loading