Skip to content

fix: missing make/model when geotagging with gpx #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptpt merged 1 commit into from
Feb 10, 2025
Merged

fix: missing make/model when geotagging with gpx #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mapillary_tools/video_data_extraction/extractors/gopro_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ def extract_points(self) -> T.Sequence[geo.Point]:
return []

def extract_make(self) -> T.Optional[str]:
model = self.extract_model()
if model:
return "GoPro"

# make sure self.pointsFound is updated
_ = self.extract_points()
# If no points were found, assume this is not a GoPro
return "GoPro" if self.pointsFound else None

Expand Down
7 changes: 5 additions & 2 deletions mapillary_tools/video_data_extraction/extractors/gpx_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from ... import geo
from ...geotag import geotag_images_from_gpx_file
from .base_parser import BaseParser
from .generic_video_parser import GenericVideoParser


class GpxParser(BaseParser):
Expand All @@ -23,7 +24,9 @@ def extract_points(self) -> T.Sequence[geo.Point]:
return points

def extract_make(self) -> T.Optional[str]:
return None
parser = GenericVideoParser(self.videoPath, self.options, self.parserOptions)
return parser.extract_make()

def extract_model(self) -> T.Optional[str]:
return None
parser = GenericVideoParser(self.videoPath, self.options, self.parserOptions)
return parser.extract_model()
Loading