Skip to content

Fix missing HibernateAccounting class#3949

Draft
lanseg wants to merge 3 commits intomasterfrom
clustering-spring7-fix
Draft

Fix missing HibernateAccounting class#3949
lanseg wants to merge 3 commits intomasterfrom
clustering-spring7-fix

Conversation

@lanseg
Copy link
Contributor

@lanseg lanseg commented Jan 29, 2026

No description provided.

@lanseg lanseg force-pushed the clustering-spring7-fix branch from 04076fd to a1cc61f Compare January 29, 2026 10:24
@lanseg lanseg requested review from sbrunner and sebr72 February 2, 2026 14:01
@lanseg lanseg marked this pull request as ready for review February 2, 2026 14:01
@lanseg
Copy link
Contributor Author

lanseg commented Feb 2, 2026

That pull request only addresses the db connection and querying issues. It's a bit similar to @sbrunner's #3943, but doesn't touch the CI/CD test running workflows

Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Could you please add a test, justifying why these changes were required ?

@lanseg
Copy link
Contributor Author

lanseg commented Feb 3, 2026

Thanks for the fixes. Could you please add a test, justifying why these changes were required ?

The failure happens because of the difference in the mapfish_spring_hibernate.xml files:

  • test/.../mapfish_spring_hibernate.xml had the line "org.mapfish.print.servlet.job"
  • src/.../mapfish_spring_hibernate.xml didn't have this line

So the tests were not validating the behavior at runtime.

@lanseg lanseg requested a review from sebr72 February 3, 2026 11:00
@lanseg lanseg marked this pull request as draft February 4, 2026 16:52
@lanseg
Copy link
Contributor Author

lanseg commented Feb 6, 2026

The last commit (ef04b27) is needed to reduce amount of the database structure changes, e.g.:

Old Spring / Hibernate New Spring / Hibernate New with explicit types
layout TEXT NOT NULL layout character varying (255) layout TEXT NOT NULL

The full DB structure comparison was done using the following steps:

  1. Start DB and the print server based on the "old" spring.
  2. Do 100 print requests, then dump the database contents (spring5_dump.sql.zip)
  3. Stop the spring5 print server, start the spring 7 print serve, dump the database contents (spring7_dump.sql.zip)
  4. Do 100 print requests, then dump the database contents (spring7_updated_dump.sql.zip)

The results were in line with expectations:

  • spring5_dump.sql and spring7_dump.sql have exactly the same CREATE and COPY statements, which means the migration will not destroy an existing data.
  • spring5_dump.sql and spring7_dump_updated.sql have exactly the same CREATE statements, the COPY statement has 200 lines (100 from step 2, 100 more from step 4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants