Draft
Conversation
04076fd to
a1cc61f
Compare
Contributor
Author
sebr72
requested changes
Feb 2, 2026
Contributor
sebr72
left a comment
There was a problem hiding this comment.
Thanks for the fixes. Could you please add a test, justifying why these changes were required ?
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/servlet/job/impl/hibernate/PrintJobDao.java
Show resolved
Hide resolved
Contributor
Author
The failure happens because of the difference in the mapfish_spring_hibernate.xml files:
So the tests were not validating the behavior at runtime. |
Contributor
Author
|
The last commit (ef04b27) is needed to reduce amount of the database structure changes, e.g.:
The full DB structure comparison was done using the following steps:
The results were in line with expectations:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.