Move prebuildify to dev dependencies #195
Conversation
…system toolchain when MASON_LLVM_RELEASE="system" is set in the CI environment.
miafan23
force-pushed
the
move-prebuildify-to-dev
branch
from
f207d74 to
11e3ac4
Compare
| "test": "./node_modules/.bin/tape test/**/*.test.js", | ||
| "prebuildify": "prebuildify --napi --tag-uv --tag-libc --strip" | ||
| "prebuildify": "prebuildify --napi --tag-uv --tag-libc --strip", | ||
| "prepublishOnly": "npm run download-binaries" |
There was a problem hiding this comment.
I'd remove prebuilds first, and after download-binaries throw an error if one of the platforms is missing, otherwise it's easy to publish binaries from a previous release.
Also, can we check that binaries are built from the current gitsha? Like maybe add the gitsha to artifact name or something?
This whole process feels very brittle right now
There was a problem hiding this comment.
Also, can we check that binaries are built from the current gitsha? Like maybe add the gitsha to artifact name or something?
When the CI is not done on my new push, I am not able to download binaries, so I guess it works like this?
There was a problem hiding this comment.
@AlexanderBelokon Thanks for the review. Updated the script ed67262
Co-authored-by: SanD <alexander@belokon.net>
Co-authored-by: AlexanderBelokon <alexander.belokon@mapbox.com> Co-authored-by: SanD <alexander@belokon.net>
2 participants
Uh oh!
There was an error while loading. Please reload this page.