Skip to content

Fix bug where re-adding component on style change fails #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathonwpowell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix bug where re-adding component on style change fails #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/directions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,22 @@ export default class MapboxDirections {
if (controls.instructions) el.appendChild(directionsEl);

this.subscribedActions();
if (this._map.loaded()) this.mapState()
else this._map.on('load', () => this.mapState());

/*
* We are subscribing to idle here instead of load as loaded() returns true if
* the map is loading at any time, but the load event only triggers on the first
* complete load. This means if we are changing style after the first load and are
* trying to add the component, it will not add anything subscribed to load.
*/
var _this5 = this;
if (this._map.loaded()) {
this.mapState();
} else {
this._map.on('idle', function onMapIdleSetState() {
_this5._map.off('idle', onMapIdleSetState);
_this5.mapState();
});
}

return el;
}
Expand Down