Skip to content

Use unique names for the lambda policies #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryndaniels merged 2 commits into from
Nov 27, 2025
Merged

Use unique names for the lambda policies #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b3080
Use unique names for the lambda policies
ryndaniels Nov 26, 2025
35faf5e
Changelog
ryndaniels Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
# Changelog

## 9.1.0

- Change the policy name for the Lambda shortcuts to include the stack's LogicalName

## 9.0.0

- Removes:
- Removes:
- aws-sdk as a runtime dependency.
- All node support prior to version 20.
- Adds:
- Adds:
- `@aws-sdk/client-cloudformation` as a runtime dependency.
- Updates:
- Updates:
- bin/validate-template to use `@aws-sdk/client-cloudformation`.
- Lambda shortcut lambda runtime default to use `node22.x`

Expand Down
2 changes: 1 addition & 1 deletion lib/shortcuts/lambda.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class Lambda {
Condition,
DependsOn: (RoleArn) ? undefined : `${LogicalName}Role`,
Properties: {
PolicyName: 'lambda-log-access',
PolicyName: `${LogicalName}-lambda-log-access`,
Roles: [roleName],
PolicyDocument: {
Version: '2012-10-17',
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/event-lambda-custom-eventbus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/event-lambda-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/event-lambda-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
6 changes: 3 additions & 3 deletions test/fixtures/shortcuts/hookshot-github-compatible-legacy-node-runtimes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
},
"Handler": "index.lambda",
"MemorySize": 128,
"Runtime": "nodejs16.x",
"Runtime": "nodejs22.x",
"Timeout": 30,
"Role": {
"Fn::GetAtt": [
Expand Down Expand Up @@ -225,7 +225,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -366,7 +366,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-github-secret-ref.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -372,7 +372,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-github-secret-string.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -366,7 +366,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-github.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -374,7 +374,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough-access-log-format.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -370,7 +370,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough-alarms.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -354,7 +354,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
6 changes: 3 additions & 3 deletions test/fixtures/shortcuts/hookshot-passthrough-compatible-legacy-node-runtimes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
},
"Handler": "index.lambda",
"MemorySize": 128,
"Runtime": "nodejs16.x",
"Runtime": "nodejs22.x",
"Timeout": 30,
"Role": {
"Fn::GetAtt": [
Expand Down Expand Up @@ -211,7 +211,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -352,7 +352,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough-enhanced-logging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -352,7 +352,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough-full-blown-logging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -352,7 +352,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough-logging.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -352,7 +352,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/shortcuts/hookshot-passthrough.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "PassFunctionRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "PassFunction-lambda-log-access",
"Roles": [
{
"Ref": "PassFunctionRole"
Expand Down Expand Up @@ -352,7 +352,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "DestinationRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "Destination-lambda-log-access",
"Roles": [
{
"Ref": "DestinationRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/lambda-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/lambda-docker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/lambda-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
"Condition": "Always",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/lambda-provided-role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"MyLambdaLogPolicy": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Fn::Select": [
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/lambda-zipfile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/log-subscription-lambda-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/log-subscription-lambda-no-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/queue-lambda-zero.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/queue-lambda.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/scheduled-lambda-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/scheduled-lambda-full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/stream-lambda-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/shortcuts/stream-lambda-no-defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"Type": "AWS::IAM::Policy",
"DependsOn": "MyLambdaRole",
"Properties": {
"PolicyName": "lambda-log-access",
"PolicyName": "MyLambda-lambda-log-access",
"Roles": [
{
"Ref": "MyLambdaRole"
Expand Down
Loading