Skip to content

Fix water refraction bleeding #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
URAKOLOUY5 wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Fix water refraction bleeding #488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cd6f64
Reduce clear color bleeding for water
URAKOLOUY5 Nov 3, 2025
096d659
Add "r_water_use_fix_for_bleeding"
URAKOLOUY5 Nov 3, 2025
dc0609e
I can't prove that
URAKOLOUY5 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions sp/src/game/client/viewrender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ static ConVar r_ForceWaterLeaf( "r_ForceWaterLeaf", "1", 0, "Enable for optimiza
static ConVar mat_drawwater( "mat_drawwater", "1", FCVAR_CHEAT );
static ConVar mat_clipz( "mat_clipz", "1" );

#ifdef MAPBASE
static ConVar r_water_use_fix_for_bleeding("r_water_use_fix_for_bleeding", "1", FCVAR_ARCHIVE, "Enable hack that adjusts the clipping plane so it fixes bleeding");
#endif


//-----------------------------------------------------------------------------
// Other convars
Expand Down Expand Up @@ -6595,6 +6599,12 @@ void CAboveWaterView::CRefractionView::Setup()
m_DrawFlags = DF_RENDER_REFRACTION | DF_CLIP_Z |
DF_RENDER_UNDERWATER | DF_FUDGE_UP |
DF_DRAW_ENTITITES ;

#ifdef MAPBASE
// Single check if enough, no need to repeat that in Draw just for +2.f
if (r_water_use_fix_for_bleeding.GetBool())
m_DrawFlags |= DF_RENDER_ABOVEWATER;
#endif
}


Expand All @@ -6611,11 +6621,19 @@ void CAboveWaterView::CRefractionView::Draw()
int nSaveViewID = CurrentViewID();
SetupCurrentView( origin, angles, VIEW_REFRACTION );

#ifdef MAPBASE
DrawSetup( GetOuter()->m_waterHeight + 2.f, m_DrawFlags, GetOuter()->m_waterZAdjust );
#else
DrawSetup( GetOuter()->m_waterHeight, m_DrawFlags, GetOuter()->m_waterZAdjust );
#endif

SetFogVolumeState( GetOuter()->m_fogInfo, true );
SetClearColorToFogColor();
#ifdef MAPBASE
DrawExecute( GetOuter()->m_waterHeight + 2.f, VIEW_REFRACTION, GetOuter()->m_waterZAdjust );
#else
DrawExecute( GetOuter()->m_waterHeight, VIEW_REFRACTION, GetOuter()->m_waterZAdjust );
#endif

#ifdef PORTAL
// deal with stencil
Expand Down