Fix for passenger movement msgs#241
Open
bozimmerman wants to merge 1 commit intomangoszero:masterfrom
Open
Conversation
bozimmerman
force-pushed
the
fix_passenger_mvmt
branch
from
0966b33 to
2bdd7bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with not being able to see other players move around on a Transport. Discovered during testing Bot transport riding, but not really Bot-related. If I logged two clients in, and put them both on the same ship, I wasn't able to see the players moving. The fix was simply to make sure the clients get those messages when a player is on a transport.
I think the reason this bug occurs is because ships aren't part of the grid system that is used for normal movement notifications, making this weird work-around necessary.
This change is