Open
Conversation
2336c3e to
15ce44d
Compare
15ce44d to
47162ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows PlayerBots to follow players onto Boats, and disembark them when the player leaves.
The implemented behavior is that the Bot follows the player on to the Boat, at the position they were at after a few seconds, and then does not move until disembarked. There may be some visual "snapping", and multiple bots will end up on top of each other. Player movement on boats is almost entirely client-enforced, so this was a particularly troublesome fix, and took me months to figure out. I'm telling you this because I deserve pity :)
Trams and Lifts still don't work, but it's on my TODO list, after Pets. Now that I understand "Transport" (Ship) movement much better, these others should be simpler.
This change is