Skip to content

Fix false positive in send HTTP request#1099

Merged
mike-hunhoff merged 3 commits intomandiant:masterfrom
saniyafatima07:san
Jan 26, 2026
Merged

Fix false positive in send HTTP request#1099
mike-hunhoff merged 3 commits intomandiant:masterfrom
saniyafatima07:san

Conversation

@saniyafatima07
Copy link
Copy Markdown
Contributor

Closes #1093

Fixes false positive in send HTTP request using string literals "GET " and "POST "

Copy link
Copy Markdown
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saniyafatima07 ! Quick question for your review.

Comment thread communication/http/client/send-http-request.yml Outdated
@saniyafatima07
Copy link
Copy Markdown
Contributor Author

@mike-hunhoff Refined the approach by using anchored regex patterns.
Could you please review? Thank you.

Comment thread communication/http/client/send-http-request.yml Outdated
@saniyafatima07
Copy link
Copy Markdown
Contributor Author

saniyafatima07 commented Jan 24, 2026

@mike-hunhoff Done with the changes. Could you please review.
Thank you!

Copy link
Copy Markdown
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @saniyafatima07 . LGTM 🚀

@mike-hunhoff mike-hunhoff merged commit 8caf489 into mandiant:master Jan 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

send HTTP request

2 participants