Skip to content

add duration intermediate type documentation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitiral wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add duration intermediate type documentation #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/documentation/language/datatypes.malloynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,25 @@ Ranges may be used in conjunction with the [apply operator](apply.malloynb) to t

In the future, other ranges may be allowed, such as `string` ranges.

### Duration

Durations can be added to timestamps and dates.

* `@2001-02-03 04:05 + 5 minutes`
* `@2001-02-03 04:05 + myHours hours`
* `@2021-01-01 + 5 weeks`
* `@0000-01-01 + myYear years + (daysIntoMyYear - 1) days`

Comment on lines +129 to +137
Copy link
Contributor

@mtoy-googly-moogly mtoy-googly-moogly Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this.

A few notes.

  1. Durations can be added or subtracted.
  2. The legal units for durations are, i think, microseconds, milliseconds, seconds, minutes, hours, days, weeks.
  3. SQL durations, if the database has them, are not imported and useful as Malloy durations.

Copy link
Author

@vitiral vitiral Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added years to your list of legal units 😄

Copy link
Author

@vitiral vitiral Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also modified point3 for clarity.

A few notes:

1. Durations can be added or subtracted.

2. The legal units for durations are: microseconds, milliseconds,
seconds, minutes, hours, days, weeks, years.

3. SQL durations, if the database has them, are not imported and cannot be used
as Malloy durations.

### Alternations and Partials

_Partials_ represent a "part of" a comparison.
Expand Down