Skip to content

Fix spurious columns_created in get() result and reduce cyclomatic complexity #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maksii merged 2 commits into from
Feb 28, 2026
Merged

Fix spurious columns_created in get() result and reduce cyclomatic complexity #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c3efb
Initial plan
Copilot Feb 28, 2026
92ca6bd
Fix get() result: remove columns_created, reduce cyclomatic complexity
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/PowerPlatform/Dataverse/operations/tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ def get(
"table_logical_name": raw.get("LogicalName"),
"entity_set_name": raw.get("EntitySetName"),
"metadata_id": raw.get("MetadataId"),
"columns_created": [],
}

# Include any extra selected entity properties
Expand All @@ -248,12 +247,13 @@ def get(

# Include expanded relationship collections as raw dicts
if include_relationships:
if "OneToManyRelationships" in raw:
result["one_to_many_relationships"] = raw["OneToManyRelationships"]
if "ManyToOneRelationships" in raw:
result["many_to_one_relationships"] = raw["ManyToOneRelationships"]
if "ManyToManyRelationships" in raw:
result["many_to_many_relationships"] = raw["ManyToManyRelationships"]
for raw_key, result_key in (
("OneToManyRelationships", "one_to_many_relationships"),
("ManyToOneRelationships", "many_to_one_relationships"),
("ManyToManyRelationships", "many_to_many_relationships"),
):
if raw_key in raw:
result[result_key] = raw[raw_key]

return result

Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_tables_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ def test_get_with_include_columns(self):
include_many_to_many=False,
)
self.assertIn("columns", result)
self.assertNotIn("columns_created", result)
self.assertEqual(len(result["columns"]), 1)
self.assertIsInstance(result["columns"][0], ColumnMetadata)
self.assertEqual(result["columns"][0].logical_name, "name")
Expand Down