pipeline & dockerfile#2
Open
lxfrdl wants to merge 6 commits into
Open
Conversation
agiledivider
added a commit
that referenced
this pull request
May 4, 2026
…type Resolves BACKLOG #1 and #2. #1 — DiscordHandlerOptions.logger was typed optional but used unconditionally throughout the class; constructing without a logger threw TypeError on every internal log call. The constructor now defaults to pino({ level: "silent" }) and the field is typed as required BaseLogger so the compiler can prove every `this.logger.X` call is safe. Same defaulting applied to ActionLoader. #2 — `private services: any` initialised as `[]` and used as an object map worked only because string-keyed properties on arrays remain enumerable in object spread. Replaced with `Record<string, unknown> = {}` (field initialiser; constructor assignment removed). Semantics unchanged. Two new tests verify the bot constructs and start()s without a logger. Type-check error count drops from 86 to 76 (-10, all of which were "Object is possibly 'undefined'" on logger calls).
agiledivider
added a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline repaired and updated; multiarch build integrated