Skip to content

fix: use python3 JSON parser in checkLatestRelease() instead of grep #8808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vijaygovindaraja wants to merge 2 commits into
base: preview
Choose a base branch
from
+14 −4
Open

fix: use python3 JSON parser in checkLatestRelease() instead of grep #8808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8be000c
fix: use python3 JSON parser in checkLatestRelease() instead of grep
Mar 27, 2026
1b4d095
fix: add python3 preflight check and address review feedback
Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions deployments/cli/community/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,18 @@ function spinner() {

function checkLatestRelease(){
echo "Checking for the latest release..." >&2
local latest_release=$(curl -sSL https://api.github.com/repos/$GH_REPO/releases/latest | grep -o '"tag_name": "[^"]*"' | sed 's/"tag_name": "//;s/"//g')
if ! command -v python3 &> /dev/null; then
echo "python3 is required but not installed. Please install Python 3 and try again." >&2
exit 1
fi
local latest_release
latest_release=$(curl -fsSL "https://api.github.com/repos/$GH_REPO/releases/latest" | python3 -c "import sys,json; print(json.load(sys.stdin)['tag_name'])" 2>/dev/null)
if [ -z "$latest_release" ]; then
echo "Failed to check for the latest release. Exiting..." >&2
exit 1
fi

echo $latest_release
echo "$latest_release"
}

function initialize(){
Expand Down
9 changes: 7 additions & 2 deletions deployments/swarm/community/swarm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,18 @@ EOF

function checkLatestRelease(){
echo "Checking for the latest release..." >&2
local latest_release=$(curl -s https://api.github.com/repos/$GH_REPO/releases/latest | grep -o '"tag_name": "[^"]*"' | sed 's/"tag_name": "//;s/"//g')
if ! command -v python3 &> /dev/null; then
echo "python3 is required but not installed. Please install Python 3 and try again." >&2
exit 1
fi
local latest_release
latest_release=$(curl -fsSL "https://api.github.com/repos/$GH_REPO/releases/latest" | python3 -c "import sys,json; print(json.load(sys.stdin)['tag_name'])" 2>/dev/null)
if [ -z "$latest_release" ]; then
echo "Failed to check for the latest release. Exiting..." >&2
exit 1
fi

echo $latest_release
echo "$latest_release"
}

# Function to read stack name from env file
Expand Down