-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: redesign intake action buttons and use design tokens #8799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+151
−75
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,8 +6,17 @@ | |||||||
|
|
||||||||
| import React from "react"; | ||||||||
| import { observer } from "mobx-react"; | ||||||||
| import { CircleCheck, CircleX, Clock, FileStack, PanelLeft, MoveRight } from "lucide-react"; | ||||||||
| import { LinkIcon, NewTabIcon, TrashIcon, ChevronDownIcon, ChevronUpIcon } from "@plane/propel/icons"; | ||||||||
| import { Clock, FileStack, MoreHorizontal, PanelLeft, MoveRight } from "lucide-react"; | ||||||||
| import { IconButton, getIconButtonStyling } from "@plane/propel/icon-button"; | ||||||||
| import { | ||||||||
| LinkIcon, | ||||||||
| NewTabIcon, | ||||||||
| TrashIcon, | ||||||||
| ChevronDownIcon, | ||||||||
| ChevronUpIcon, | ||||||||
| CheckCircleFilledIcon, | ||||||||
| CloseCircleFilledIcon, | ||||||||
| } from "@plane/propel/icons"; | ||||||||
| import type { TNameDescriptionLoader } from "@plane/types"; | ||||||||
| import { Header, CustomMenu, EHeaderVariant } from "@plane/ui"; | ||||||||
| import { cn, findHowManyDaysLeft, generateWorkItemLink } from "@plane/utils"; | ||||||||
|
|
@@ -102,20 +111,20 @@ export const InboxIssueActionsMobileHeader = observer(function InboxIssueActions | |||||||
| /> | ||||||||
| <div className="z-[15] flex w-full items-center gap-2 bg-surface-1"> | ||||||||
| <div className="flex items-center gap-x-2"> | ||||||||
| <button | ||||||||
| type="button" | ||||||||
| className="rounded-sm border border-subtle p-1.5" | ||||||||
| <IconButton | ||||||||
| variant="secondary" | ||||||||
| size="lg" | ||||||||
| icon={ChevronUpIcon} | ||||||||
| aria-label="Previous work item" | ||||||||
| onClick={() => handleInboxIssueNavigation("prev")} | ||||||||
| > | ||||||||
| <ChevronUpIcon height={14} width={14} strokeWidth={2} /> | ||||||||
| </button> | ||||||||
| <button | ||||||||
| type="button" | ||||||||
| className="rounded-sm border border-subtle p-1.5" | ||||||||
| /> | ||||||||
| <IconButton | ||||||||
| variant="secondary" | ||||||||
| size="lg" | ||||||||
| icon={ChevronDownIcon} | ||||||||
| aria-label="Next work item" | ||||||||
| onClick={() => handleInboxIssueNavigation("next")} | ||||||||
| > | ||||||||
| <ChevronDownIcon height={14} width={14} strokeWidth={2} /> | ||||||||
| </button> | ||||||||
| /> | ||||||||
| </div> | ||||||||
| <div className="flex items-center gap-4"> | ||||||||
| <InboxIssueStatus inboxIssue={inboxIssue} iconSize={12} /> | ||||||||
|
|
@@ -124,7 +133,11 @@ export const InboxIssueActionsMobileHeader = observer(function InboxIssueActions | |||||||
| </div> | ||||||||
| </div> | ||||||||
| <div className="ml-auto"> | ||||||||
| <CustomMenu verticalEllipsis placement="bottom-start"> | ||||||||
| <CustomMenu | ||||||||
| customButton={<MoreHorizontal className="size-4" />} | ||||||||
| customButtonClassName={getIconButtonStyling("secondary", "lg")} | ||||||||
| placement="bottom-start" | ||||||||
|
||||||||
| placement="bottom-start" | |
| placement="bottom-start" | |
| ariaLabel="More actions" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
packages/propel/src/icons/misc/check-circle-filled-icon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * Copyright (c) 2023-present Plane Software, Inc. and contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| * See the LICENSE file for details. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| import { IconWrapper } from "../icon-wrapper"; | ||
| import type { ISvgIcons } from "../type"; | ||
|
|
||
| export const CheckCircleFilledIcon: React.FC<ISvgIcons> = ({ color = "currentColor", ...rest }) => { | ||
| const clipPathId = React.useId(); | ||
|
|
||
| return ( | ||
| <IconWrapper color={color} clipPathId={clipPathId} {...rest}> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M7.99984 0.666992C3.94975 0.666992 0.666504 3.95024 0.666504 8.00033C0.666504 12.0504 3.94975 15.3337 7.99984 15.3337C12.0499 15.3337 15.3332 12.0504 15.3332 8.00033C15.3332 3.95024 12.0499 0.666992 7.99984 0.666992ZM11.4712 6.47173C11.7316 6.21138 11.7316 5.78927 11.4712 5.52892C11.2109 5.26857 10.7888 5.26857 10.5284 5.52892L6.99984 9.05752L5.47124 7.52892C5.21089 7.26857 4.78878 7.26857 4.52843 7.52892C4.26808 7.78927 4.26808 8.21138 4.52843 8.47173L6.52843 10.4717C6.78878 10.7321 7.21089 10.7321 7.47124 10.4717L11.4712 6.47173Z" | ||
| fill={color} | ||
| /> | ||
| </IconWrapper> | ||
| ); | ||
| }; |
25 changes: 25 additions & 0 deletions
25
packages/propel/src/icons/misc/close-circle-filled-icon.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * Copyright (c) 2023-present Plane Software, Inc. and contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| * See the LICENSE file for details. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
|
|
||
| import { IconWrapper } from "../icon-wrapper"; | ||
| import type { ISvgIcons } from "../type"; | ||
|
|
||
| export const CloseCircleFilledIcon: React.FC<ISvgIcons> = ({ color = "currentColor", ...rest }) => { | ||
| const clipPathId = React.useId(); | ||
|
|
||
| return ( | ||
| <IconWrapper color={color} clipPathId={clipPathId} {...rest}> | ||
| <path | ||
| fillRule="evenodd" | ||
| clipRule="evenodd" | ||
| d="M7.99984 0.666992C3.94975 0.666992 0.666504 3.95024 0.666504 8.00033C0.666504 12.0504 3.94975 15.3337 7.99984 15.3337C12.0499 15.3337 15.3332 12.0504 15.3332 8.00033C15.3332 3.95024 12.0499 0.666992 7.99984 0.666992ZM10.4712 5.52892C10.7316 5.78927 10.7316 6.21138 10.4712 6.47173L8.94265 8.00033L10.4712 9.52892C10.7316 9.78927 10.7316 10.2114 10.4712 10.4717C10.2109 10.7321 9.78878 10.7321 9.52843 10.4717L7.99984 8.94313L6.47124 10.4717C6.21089 10.7321 5.78878 10.7321 5.52843 10.4717C5.26808 10.2114 5.26808 9.78927 5.52843 9.52892L7.05703 8.00033L5.52843 6.47173C5.26808 6.21138 5.26808 5.78927 5.52843 5.52892C5.78878 5.26857 6.21089 5.26857 6.47124 5.52892L7.99984 7.05752L9.52843 5.52892C9.78878 5.26857 10.2109 5.26857 10.4712 5.52892Z" | ||
| fill={color} | ||
| /> | ||
| </IconWrapper> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CustomMenuis being rendered with an icon-onlycustomButtonbut without anariaLabel. SinceCustomMenuforwardsariaLabelto the underlying<button aria-label=...>, this control currently has no accessible name for screen readers. Please provide an appropriateariaLabel(e.g., "More actions").