Merged
Conversation
Introduce GPU-accelerated hydro flow particle simulation with stream-order- aware rendering, trail visualization, and accumulation-scaled particle sizing. New HydroState subsystem follows the composed viewer pattern. Trinidad example now launches with hydro=True.
…on rasterization - Burn Overture waterway LineStrings and Polygons into DEM before D8 computation so flow routes through known channels (quickstart) - Add distance-to-ocean gradient and channel burning pass for better coastal drainage and stream connectivity - Toggle hydro (Shift+Y) now switches to stream_link overlay with water reflection shader, restoring previous layer on OFF - Rasterize waterway Polygons (lakes/reservoirs) via scanline fill in both engine and quickstart, not just LineStrings - Burn waterway features into stream_link and stream_order grids so they render with the unified water shader - Update stream order palette to blue gradient (8 levels) and remove HDR emissive boost for natural water appearance - Reduce default hydro particle count to 12k and min render depth to 1m
Add _trace_tributaries_flow_path() using xrspatial flow_path to trace waterway-seeded channels and headwater tributaries into the stream network. Add coast_distance parameter using xrspatial surface_distance for terrain-aware 3D Dijkstra distance from coastline.
…plore() The hydro block in quickstart() created ~20 intermediate (H,W) arrays that were never freed before explore() blocked indefinitely. On a 4096x4096 DEM this leaked ~1.3 GB of dead CPU arrays plus stale CuPy pool memory, causing OOM kills on WSL. - Add explicit del for all intermediate arrays after last use - Load waterway GeoJSON once instead of 4 redundant file reads - Free CuPy memory pool between heavy computation steps - gc.collect() before launching explore() - Clean up coast_distance intermediates similarly - Store boolean flag in _hydro_data instead of (flow_dir, flow_accum) tuple that redundantly kept two full grids alive during viewer session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HydroStatesubsystem (rtxpy/viewer/hydro.py) following the composed viewer patternhydro_dataparameter throughaccessor.explore(),quickstart(), andengine.pyhydro=TrueTest plan
python examples/trinidad.pyand verify hydro flow particles render on terrain