Open
Conversation
Owner
|
I got a little side-tracked implementing a true POSIX/GNU option/flag parser (https://github.com/major0/optargs.git) so that I could have a real Just a heads up, I wont have time to review this until this evening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Mark! Thanks for building and maintaining this CLI!
And on a personal note, thank you for the work you do outside of tech as well! 🙏
I put this together because I needed a working way to upload a file to Proton Drive from this CLI, and the current codebase was already very close.
This PR adds a basic
drive uploadcommand and fixes a few things that were getting in the way of real uploads with Proton's current API behavior.What's included
protondrive drive uploadgo-proton-apiunderthird_party/go-proton-apiNotes
A couple of the dependency changes are bigger than I'd normally like, but I went with the most practical route to get a working upload path first.
I tested this against a real Proton account and was able to:
.gpgfile to Proton DriveKnown rough edges
If you'd prefer, I can split this into smaller PRs afterward (for example: CLI command vs API compatibility patch).