Restore compatibility with older Perl versions#882
Open
jasongill wants to merge 1 commit intomajor:masterfrom
Open
Restore compatibility with older Perl versions#882jasongill wants to merge 1 commit intomajor:masterfrom
jasongill wants to merge 1 commit intomajor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README.md indicates that the project supports Perl 5.6+, but the
rmodifier is used on two regular expressions; this modifier was not added until Perl 5.14, so the script fails on older versions of Perl.Testing on Perl 5.10, for example:
The
rmodifier for the regex is simply a shortcut that allows for a one-liner in the code, but it is not necessary for the script to function (and in fact, is only used in 2 places in the script).This pull request removes the
rmodifier and restores the replacement logic to 2 lines as opposed to the one-liner syntax that is only supported on Perl 5.14+.By merging this patch, the latest version of MySQLTuner will function on older versions of Perl again. This bug was introduced in commits 9db65eb and 79522b2