added redux-dev-tools and composeWithDevTools#6
Open
koopcodes wants to merge 1 commit intomaisonm:masterfrom
Open
added redux-dev-tools and composeWithDevTools#6koopcodes wants to merge 1 commit intomaisonm:masterfrom
koopcodes wants to merge 1 commit intomaisonm:masterfrom
Conversation
koopcodes
commented
Oct 26, 2018
| @@ -1,16 +1,15 @@ | |||
| import { createStore, applyMiddleware, compose } from 'redux'; | |||
| import { createStore, applyMiddleware } from 'redux'; | |||
Author
There was a problem hiding this comment.
No longer need to import compose.....
koopcodes
commented
Oct 26, 2018
| import createSagaMiddleware from 'redux-saga'; | ||
| import rootReducer from './reducers/index'; | ||
| import rootSaga from './sagas/index'; | ||
| import { composeWithDevTools } from 'redux-devtools-extension'; |
Author
There was a problem hiding this comment.
because we are importing and going to use composeWithDevTools
koopcodes
commented
Oct 26, 2018
| compose(applyMiddleware(sagaMiddleware), reduxDevTools) | ||
| ); | ||
| composeWithDevTools(applyMiddleware(sagaMiddleware)) | ||
| ); |
Author
There was a problem hiding this comment.
No need to assign DevTools as a constant and include it in the compose, composeWithDevTools alone is sufficient
koopcodes
commented
Oct 26, 2018
| "react-scripts": "1.1.4", | ||
| "redux": "^4.0.0" | ||
| }, | ||
| "devDependencies": { |
Author
There was a problem hiding this comment.
Locally it worked for me installing redux-dev-tools as a client dev dependency but in order to have it deploy to Heroku I had to include it in the root package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was written
/client/src/store/index.jswould only work for me using Chrome browser with the Redux DevTools extension installed. By adding npm package redux-dev-tools to client package.json and some changes to/client/src/store/index.jsit now runs in all browsers I was able to test