Open
Conversation
Owner
|
Thanks for the PR! I won't merge it right now though as I am still implementing stuff over at @conventional-commits-rs to allow for automatic version releases. Once I've setup that, I will merge this. Doesn't really make sense to include self update functionality if the only way to install it right now is through cargo itself :) |
Author
|
Makes complete sense! Feel free to leave this here until it is useful to merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the feature mentioned in #30 .
Everything looks fine. We could add a specific
clap::Argin order to allow the user go for the update directly instead of notifying him every single time there's a new release out. But since I only check major release changes, the user won't probably get too many messages.This is the output I get atm:
As you see, there's a problem, it comes from: jaemk/self_update#52 and we have two options. Even this issue gets fixed there (not a big deal I think since looks pretty easy to solve). Or we rather publish releases depending on the target where they'll be built for.
In any case, let me know your thoughts @sirwindfield 😄