Fix eBay API initialization with site parameter

lib/ebay_api.rb

@@ -27,6 +27,8 @@ class EbayAPI < Evil::Client
   require_relative "ebay_api/middlewares"
   require_relative "ebay_api/exceptions"
 
+  I18n.load_path += Dir[File.join(GEM_ROOT, *%w[config locales ** *.{yml,yaml}])]
+
   class << self
     attr_accessor :logger
   end

lib/ebay_api/models/site.rb

@@ -44,6 +44,15 @@ def merge(other)
 
     # Enumberable collection of the eBay marketplaces
     class << self
+      # Override new to handle hash argument from Evil::Client::Dictionary
+      def new(attributes = {})
+        if attributes.is_a?(Hash) && !attributes.empty?
+          super(**attributes)
+        else
+          super
+        end
+      end
+
       sites_file = File.join(GEM_ROOT, %w[config sites.yml])
       include Evil::Client::Dictionary[sites_file]
 

spec/models/site_spec.rb

@@ -73,4 +73,47 @@
       expect(subject).to eq "Canadian"
     end
   end
+
+  describe ".new" do
+    context "when initialized with a hash argument" do
+      let(:hash_attrs) do
+        {
+          id: 0,
+          code: "EBAY-US",
+          country: "US",
+          host: "www.ebay.com",
+          key: "EBAY_US",
+          currencies: ["USD"],
+          languages: ["en-US"]
+        }
+      end
+
+      it "properly initializes attributes from hash" do
+        site = described_class.new(hash_attrs)
+        expect(site.id).to eq(0)
+        expect(site.code).to eq("EBAY-US")
+        expect(site.country).to eq("US")
+        expect(site.host).to eq("www.ebay.com")
+        expect(site.key).to eq("EBAY_US")
+        expect(site.currencies.first.code).to eq("USD")
+        expect(site.languages.first).to eq("en-US")
+      end
+    end
+
+    context "when initialized with keyword arguments" do
+      it "properly initializes attributes from keywords" do
+        site = described_class.new(
+          id: 0,
+          code: "EBAY-US",
+          country: "US",
+          host: "www.ebay.com",
+          key: "EBAY_US"
+        )
+        expect(site.id).to eq(0)
+        expect(site.code).to eq("EBAY-US")
+        expect(site.country).to eq("US")
+        expect(site.host).to eq("www.ebay.com")
+      end
+    end
+  end
 end

spec/spec_helper.rb

@@ -16,7 +16,3 @@
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 end
-
-I18n.available_locales = %i[en]
-I18n.locale = :en
-I18n.load_path += ["config/locales/en.yml"]