feat: add GCS asset upload support between build and deploy#15
Open
yusufcemalcelebi wants to merge 5 commits intomainfrom
Open
feat: add GCS asset upload support between build and deploy#15yusufcemalcelebi wants to merge 5 commits intomainfrom
yusufcemalcelebi wants to merge 5 commits intomainfrom
Conversation
- Add gcs_asset_bucket and gcs_asset_path inputs - When gcs_asset_bucket is set, split skaffold 'run' into build + deploy - Extract build assets from Docker image and upload to GCS before deploy - Prevents 404s for hashed Vite files during rolling Kubernetes deployments
- Add configurable skaffold_tags_file input instead of hardcoded /tmp path - Move helm repo add to deploy step only (not needed for build) - Add cluster guard to deploy step condition - Add skaffold_profile guard to GCS upload step condition - Migrate gsutil to gcloud storage rsync - Add gs:// prefix to bucket path in gcloud storage command - Pass skaffold_extra to deploy step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skaffold runinto separatebuild→ GCS upload →deploystepsgcs_asset_bucket,gcs_asset_path,gcs_asset_dest_pathinputs to control asset extraction and upload from Docker image to GCSskaffold_tags_fileinput for configurable tags JSON path between steps (default:tags.json)helm repo add bjw-sto deploy step onlyclusterandskaffold_profileguards to deploy and GCS upload stepsContext
During rolling deployments, old pods serve HTML referencing hashed JS/CSS filenames that new pods don't have, causing 404s. Uploading all hashed assets to GCS before deploy ensures both old and new files are always available.
Test plan
gcs_asset_bucketare unaffectedskaffold_command: run) withgcs_asset_bucketset