Skip to content

Update repository files#25

Closed
SamErde wants to merge 5 commits intomaester365:mainfrom
SamErde:chore-UpdateRepositoryFiles
Closed

Update repository files#25
SamErde wants to merge 5 commits intomaester365:mainfrom
SamErde:chore-UpdateRepositoryFiles

Conversation

@SamErde
Copy link
Copy Markdown
Contributor

@SamErde SamErde commented Oct 30, 2025

Description

This pull request introduces improvements to development tooling and documentation, focusing on better PowerShell support in VS Code, workflow updates, and a more user-friendly pull request template.

Enhancements to development environment:

  • Added .vscode/launch.json to enable interactive PowerShell module debugging directly in VS Code, improving developer experience when working with the Maester.psd1 module.
  • Added .vscode/settings.json with PowerShell-specific formatting and analysis options, as well as editor settings to standardize code style and improve productivity.

Continuous integration and workflow updates:

  • Updated actions/checkout version from v4 to v5 in both .github/workflows/copy-tags.yml and .github/workflows/test-action.yml for improved security and compatibility. [1] [2] [3]

Documentation and contributor experience:

  • Refined .github/pull_request_template.md to provide clearer instructions, a more detailed description section, and improved checklist formatting for contributors.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main branch!
  • Make sure you are making a pull request against the main branch (left side). Also you should start your branch off maester-action/main.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Enable the checkbox to allow maintainer edits so the branch can be updated for a merge.
  • If changing anything in the action, make sure it still works and is backward compatible.

Review

We will try to review your pull request as soon as possible.

💖 Thank you!

@SamErde SamErde self-assigned this Oct 30, 2025
Copilot AI review requested due to automatic review settings October 30, 2025 18:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the development environment and updates project infrastructure. It adds VS Code configuration files for better PowerShell development support, upgrades GitHub Actions dependencies, and improves the pull request template for better contributor guidance.

  • Added VS Code settings and launch configurations for PowerShell development
  • Updated actions/checkout from v4 to v5 across workflow files
  • Refined the pull request template with clearer structure and improved contributor instructions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.vscode/settings.json Adds PowerShell-specific formatting rules and editor settings
.vscode/launch.json Configures interactive PowerShell module debugging session
.github/workflows/test-action.yml Updates checkout action to v5 and removes trailing whitespace
.github/workflows/copy-tags.yml Updates checkout action to v5 and removes trailing whitespace
.github/pull_request_template.md Restructures template with clearer sections and updated messaging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .vscode/settings.json
Comment thread .vscode/settings.json
Comment thread .vscode/launch.json Outdated
@SamErde SamErde requested a review from svrooij October 30, 2025 21:33
@SamErde SamErde requested a review from Copilot February 24, 2026 11:16
@SamErde SamErde added the enhancement New feature or request label Feb 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .vscode/launch.json
Comment on lines +7 to +12
{
"name": "PowerShell: Module Interactive Session",
"type": "PowerShell",
"request": "launch",
"script": "Import-Module -Name 'Maester'"
}
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launch configuration attempts to import the 'Maester' module, but this repository (maester-action) is a GitHub Action wrapper that doesn't contain the Maester PowerShell module. The Maester module is installed from PowerShell Gallery during action execution. This launch configuration may not work as intended for debugging in this repository's context. Consider either removing this configuration or updating it to debug the actual action scripts in the 'script/' directory instead.

Suggested change
{
"name": "PowerShell: Module Interactive Session",
"type": "PowerShell",
"request": "launch",
"script": "Import-Module -Name 'Maester'"
}

Copilot uses AI. Check for mistakes.
Comment thread .vscode/launch.json
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.1",
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launch.json version is set to "0.2.1", but the standard VS Code launch configuration version is "0.2.0". While this may not cause immediate issues, using the non-standard version number could lead to unexpected behavior or warnings in VS Code. Consider changing this to "0.2.0" to align with VS Code's expected schema version.

Suggested change
"version": "0.2.1",
"version": "0.2.0",

Copilot uses AI. Check for mistakes.
### Review
<!--

We will try to review your pull request as soon as possible. While your wait for a review, why not try to spread some Maester love on social media?
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "While your wait for a review" should be "While you wait for a review". The word "your" should be "you".

Suggested change
We will try to review your pull request as soon as possible. While your wait for a review, why not try to spread some Maester love on social media?
We will try to review your pull request as soon as possible. While you wait for a review, why not try to spread some Maester love on social media?

Copilot uses AI. Check for mistakes.
@SamErde SamErde deleted the chore-UpdateRepositoryFiles branch February 24, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants