fix: iOS last image now is shown after animation completes #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forked and used the library from @richardPFisk and it works perfectly. Would really appreciate it if this got merged into this library. Thanks for making this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Displaying a non-repeating sequence of images on iOS results in the image-view going blank after the animation has finished.
On Android, it does retain the last image of the sequence.
A proposed solution
If the overall UIImageView image is set before the animation has started, the last image stays on screen after the animation is finished.
stack-overflow uiimageview fix
This also makes the behaviour of iOS the same as Android.
Also, thanks for developing the react-native-image-sequence in the first place :)