-
Notifications
You must be signed in to change notification settings - Fork 37
Fix default run_card for GPU #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can i merge this? |
|
IIUC this will fix the problem that Jin has reported? |
|
Hi @oliviermattelaer sorry I will also look at this one in the afternoon. It changes the generated vector.inc, not a problem but I need to update a few scripts/tests. |
|
Hi @oliviermattelaer can you please merge #813 first? You changed the gpucpp in that PR, I will analyse this one after that merge. Thanks |
…d not the one for GPU
bbc61e3 to
8eec0c2
Compare
|
Ok, I have therefore done a rebase of the master within this branch to avoid to have to do a merge (since I do not expect everyone to branch from this branch |
Hi @oliviermattelaer very good, thanks. After including the changes from #813, I now see NO changes in generated code, so this is good to go for me (I am not at this stage testing the full workflow as you do... well I should, but I rely on you for that). So this is good to go for me. To keep it simple, I will not include the new codegen logs, it would not add anything. Just one comment/question, I see that in the heft codegen log this warning is now disappearing Has the warning disappeared because the actual issue has been fixed? Or should this still give a warning? Anyway, good to go for me. |
valassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go for me
|
I see that @roiser had already reacted with a thumbs-up to the review request, so I assume that he also approves this. I will merge this directly, I think this makes it easier to progress on other fronts. Thanks @oliviermattelaer |
With Stefan we noticed that
"output madevent_gpu" was producing a run_card with the default value set for SIMD mode...
This patch is fixing that.