Rack 3 no longer required environments#437
Merged
ioquatix merged 1 commit intomacournoyer:masterfrom Feb 16, 2025
Merged
Conversation
* when using Rack 3, don't add no longer required environments (rack.multithread/rack.multiprocess/rack.run_once/rack.version)
Collaborator
|
In the future, please avoid unrelated whitespace changes. Thanks for your contribution, this looks okay to me. |
Collaborator
It's a nice idea. |
Contributor
Author
Ok, sorry editor did everything automatically.
Great! If something else is missing and I can help just ping me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ioquatix if I understood correctly your comment in the other PR that should be it. 😄
Regarding adding tests on
rack-conform, I've looked at the code and my idea was to add a test Middleware to intercept environment. What do you think?