feat: print email#128
Closed
saiththerobo wants to merge 2 commits into
Closed
Conversation
Adds a print button to the message pane toolbar and a Ctrl+P / Cmd+P keyboard shortcut. Opens a formatted print view (header + body) in a new window and triggers the browser print dialog via win.print().
- Escape all user-controlled strings (name, email, subject, body text) through a shared esc() helper; fixes & not being escaped previously - Guard window.open() return value — returns null if browser blocks popup - Add text label and ^P kbd hint to print button on desktop, consistent with Reply/Forward/Archive
Contributor
Author
|
Superseded by #129 which includes the print feature plus full integration into the customizable shortcut system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a print action to the message pane. Clicking the Print button (or pressing Ctrl+P / Cmd+P) opens a clean printable page with the email header (From, To, Cc, Date, Subject) and full body, then triggers the browser print dialog automatically.
Changes
frontend/src/components/MessagePane.jsx—handlePrintfunction, toolbar button with label and^Pkbd hint, Ctrl+P listener wired throughpaneActionsReffrontend/src/locales/{en,de,es,fr,it,ru,zhCN}.json—message.printkey added in all 7 localesTesting
&renders correctly in the print view (properly escaped)Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).