Various improvements#260
Open
dsynkd wants to merge 48 commits into
Open
Conversation
…r to keep square brackets, fix bug where songs were not being fetched due to 401 error from Genius
Owner
|
Such a large PR is quite difficult to review. Could you please split this into multiple smaller PRs? Also some things that I already noticed:
|
… added some additional console logs, removed changelog and tests
…st and album imports
…ers to Import Folder instead
Closed
…s that should be imported
… add option to not include empty metadata fields
…h instrumental release label
…st track count, instead of just the first one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch modernizes settings and property mapping, adds Band, Album, and Song flows (including MusicBrainz band support and optional file tree for songs), moves API secrets to Obsidian’s keychain, and fixes several music/metadata and UX bugs.
Settings & property mapping
type,id, anddataSourceare remappable;dataSourcecan be omitted for music where it does not apply.Typefrontmatter is user-configurable via mapping.aliases(with extended title normalization and tests innormalizeTitleForAlias).New / expanded media types
geniusLyricsExtract), and tests.Security & API behavior
Bugs & polish
vite.config.mts;package-lock.jsonadded/updated.Testing