feat(rokt): Complete migration of Rokt kit into v3 monorepo#1267
Draft
rmi22186 wants to merge 3 commits into
Draft
feat(rokt): Complete migration of Rokt kit into v3 monorepo#1267rmi22186 wants to merge 3 commits into
rmi22186 wants to merge 3 commits into
Conversation
508a124 to
a8c187c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
kits/roktas the TypeScript/Vite/Vitest package used by the v3 monorepo.kits/rokt/src/Rokt-Kit.tsbyte-for-byte identical to the individual Rokt kit source onrefactor/use-core-sdk-types.@mparticle/web-sdk/@mparticle/web-sdk/internaldeclarations before thecoordinated v3 release exists on npm.
Source
~/mParticle/apps/testapp/identity-examples/js/Integrations/mparticle-javascript-integration-roktsrc/Rokt-Kit.ts:refactor/use-core-sdk-typesVerification
cmpconfirmskits/rokt/src/Rokt-Kit.tsmatches the individual Rokt kit source file.npm run buildinkits/roktpasses.npm run lintinkits/roktpasses.npm testinkits/roktpasses: 207 tests.npm run lintpasses.Notes
npm run build:typesstill prints pre-existing declaration emit/type diagnostics, but the script already masks those with|| trueand emits the declaration filesconsumed by the Rokt kit build.