feat: migrate amplitude#1173
feat: migrate amplitude#1173nickolas-dimitrakas wants to merge 10 commits intoworkstation/3.0-Releasefrom
Conversation
nickolas-dimitrakas
requested review from
alexs-mparticle,
jamesnrokt and
rmi22186
nickolas-dimitrakas
force-pushed
the
feat/migrate-amplitude-kit
branch
from
fb07722 to
9dd9861
Compare
alexs-mparticle
left a comment
alexs-mparticle
left a comment
There was a problem hiding this comment.
Looks good. Got a few questions but I think this is a great start.
Also, we should update AGENTS.md to reflect that kits are now included in the repo.
@alexs-mparticle I think the AGENTS.md is a great callout, but maybe best to leave until after all the kits have been transferred over. What do you think? |
|
Discussed live and will table to after all kits have been migrated. |
| ```javascript | ||
| { | ||
| init(settings, reportingService, testMode, trackerId, userAttributes, userIdentities, appVersion, appName), | ||
| process(event), |
There was a problem hiding this comment.
I would make sure that these methods are exposed here: https://github.com/mparticle-integrations/mparticle-javascript-web-kit-wrapper/blob/master/index.js#L453
| @@ -0,0 +1,202 @@ | |||
|
|
|||
There was a problem hiding this comment.
In the new structure, should we include the license for each kit individually, or would the license apply globally for the repo? Not a lawyer 😆
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
We should probably inherit from the global prettier
| @@ -0,0 +1,3 @@ | |||
| node_modules/ | |||
There was a problem hiding this comment.
We probably can just use the main .gitignore file
| @@ -0,0 +1,47 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we share this across all kits or inherit from global?
nickolas-dimitrakas
changed the base branch from
workstation/monorepo
to
workstation/3.0-Release
2 participants
Background
What Has Changed
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)