feat: add error and warning codes for identity and roktManager#1170
feat: add error and warning codes for identity and roktManager#1170jaissica12 merged 5 commits intodevelopmentfrom
Conversation
Question: Logger.info() Log Level BehaviorLooking at the new if (this.logger.info &&
(this.logLevel === LogLevelType.Verbose || this.logLevel === LogLevelType.Warning)) {
this.logger.info(msg);
// ...
}The Questions:
Just want to confirm the log level design is intentional. 👍 |
Suggestion: Additional Test Coverage for Edge CasesThe test coverage looks solid overall, but there are a few edge cases that might be worth covering: Missing Test Scenarios:
Example scenario: // Should not crash if reportingLogger throws
logger.warning('test', ErrorCodes.IDENTITY_REQUEST);
// Even if reportingLogger.warning() throws internallyRisk: Recommendation: Not a blocker, but might prevent future issues. 🛡️ |
|



Background
What Has Changed
Screenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)