Skip to content

Conversation

@rmi22186
Copy link
Member

Background

Per our updated docs, alias requests support a parameter scope, which was only partially implemented in the web sdk previously. This update supports scope throughout the full SDK, including adding it to the public API tio make it easier for developers to pass it in as opposed to adding it as a property after an alias request is made using our createAliasRequest helper method.

What Has Changed

Add scope throughout alias request code paths, including adding device as default when not provided in order to simplify the code.

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation. - will do as part of another ticket
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@jaissica12 jaissica12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for merging this into master instead of development? I believe this should go into development

@rmi22186 rmi22186 changed the base branch from master to development December 19, 2025 21:40
@rmi22186
Copy link
Member Author

Is there a specific reason for merging this into master instead of development? I believe this should go into development

@jaissica12 - good catch. My mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants