-
Notifications
You must be signed in to change notification settings - Fork 71
feat: add device identifiers to rokt placements #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add device identifiers to rokt placements #477
Conversation
jamesnrokt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great refactor with a few minor comments
mParticle-Apple-SDK/MPRokt.m
Outdated
| NSString *idfa = resolvedUser.identities[@(MPIdentityIOSAdvertiserId)]; | ||
| if (idfa.length > 0) { | ||
| mappedAttributes[kMPRoktAttributeKeyIDFA] = idfa; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently a bug in the rokt-kit that will add the attributes only from the user object. I think @BrandonStalnaker is going to address it soon.
|
This functionality may already exist in the sdk, though it's possible its not using the key Sam wants or that it has a bug. I'm going to test through and confirm the functionality asap. |
Background
What Has Changed
selectPlacementskMPRoktAttributeKeyIDFA,kMPRoktAttributeKeyIDFV,kMPRoktAttributeKeySandbox, and internal config key constants for maintainabilityMPRokt.mtestSelectPlacementsSimpleWithValidParameters,testSelectPlacementsExpandedWithValidParameters,testSelectPlacementsSimpleWithMapping) to verify IDFA and IDFV is correctly added when availableChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)