Optimize vm a bit by reducing unnecessary calls and allocating includ… #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janveltm
reviewed
Jun 24, 2025
janveltm
reviewed
Jun 24, 2025
| // x OR y | ||
| // x > y | ||
| // x < = | ||
| func walkBinary(ctx expr.EvalContext, node *expr.BinaryNode, depth int, visitedIncludes []string) (value.Value, bool) { |
Contributor
There was a problem hiding this comment.
I don't really know much about the logic around the ok variable. But maybe to be safe change the returned value to nil wherever ok==false in evalBinary?
janveltm
approved these changes
Jun 24, 2025
added 2 commits
June 24, 2025 12:21
vitaminmoo
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e stack