Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive end-to-end testing infrastructure using Playwright to test the LinkHints browser extension. The tests verify the tutorial workflow by simulating user interactions and checking that hints appear correctly and navigation works as expected.
Key changes:
- Adds automated Playwright test suite for the tutorial workflow
- Modifies shadow DOM mode to be "open" in development builds to enable test access
- Updates CI/CD pipeline to run tests on all branches with a dedicated test job
Reviewed changes
Copilot reviewed 18 out of 29 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tutorial.spec.ts | New comprehensive e2e test file covering the tutorial workflow with hint activation, navigation, and interactions |
| tests/-snapshots/.html | HTML snapshot files for visual regression testing of shadow DOM content |
| tests/-snapshots/.png | Screenshot snapshots for visual regression testing |
| playwright.config.ts | Playwright configuration with Firefox project, timeouts, and snapshot settings |
| src/renderer/Program.ts | Changes shadow DOM mode from "closed" to "open" in development for test access |
| package.json | Adds Playwright dependencies and test:playwright script |
| package-lock.json | Lock file updates for new Playwright dependencies |
| .github/workflows/ci.yml | Restructures CI with separate deploy, check, and test jobs; adds Playwright test execution |
| CONTRIBUTING.md | Documents the new automated testing workflow |
| .prettierignore | Excludes test results and snapshot directories from formatting |
| .gitignore | Excludes test results and tool version files |
| .github/copilot-instructions.md | New comprehensive project documentation for AI assistants |
| .devcontainer/devcontainer.json | New devcontainer configuration with Playwright setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost all changes are new tests.
The exceptions are: