test#1
Open
lxga wants to merge 43 commits into
Open
Conversation
Co-authored-by: Agus Sentosa Hermawan <agus.sentosa787@gmail.com>
* Move the testing logic from the Github Actions format to a more easy to reproduce docker-compose file. * Move the codecov report upload logic from CMS to Github Actions. * Set threshold for codecov status check
…-dev#1232) Change the default setting for g++ from C++11 to C++17
Pytest has a nice auto-discovery feature (see pytest.ini file), is compatible with the unittest-style tests we're already using, and produces a far more readable output which makes it easy to see what's failing. This commit removes RunUnitTests.py and RunTests.py, leaving only RunFunctionalTests.py (which could later be migrated to pytest as well) We also rename the 'db' container to 'cms_test_db' to better distinguish it from other locally running containers and in preparation for adding docker-compose.dev.yml later on.
These files weren't running with our test runner because they weren't marked as executable. They now are (although we don't need them to be).
Split `docker build` and `docker run` in two separate workflow steps to reduce the output size in the github action and make it more readable Also improve the docker (re)build speed by better using the cache: we first copy the requirements.txt, then install, then copy the rest of the folder, which means we won't invalidate the cached `pip install` step unless we really need to
Also update gitignore / dockerignore
* add ":" after 총점 * 제출 시간 -> 제출 시각 * info * password sentence fix
… is the default one
To improve performance when connecting to worker instances over high latency network
Suggested-by: Németh Zsolt <37755878+birka0@users.noreply.github.com>
The catalog is skipped if it is marked fuzzy: catalog cms/locale/uk/LC_MESSAGES/cms.po is marked as fuzzy, skipping Fixes: 7d96215 ("Added Ukrainian translation")
Apparently neither postgres nor the SQL standard guarantees that the order of the results will match the order the of the queries[0]. If the results are not returned in order, then AWS will confuse which result belongs to which query, producing incomprehensible results on the admin page. [0]: https://dba.stackexchange.com/questions/316818/are-results-from-union-all-clauses-always-appended-in-order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.