Fix for TypeScript-Support with @types/leaflet #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for TypeScript support. See pull request for details.
Doubi88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your work, this was really helpful.
I use leaflet with TypeScript and in @types/leaflet, "fill" is declared as boolean, which is completely correct and should stay so, but that means that I cannot write the String "url(...)" to it. I solved that for my case by changing your code to use "fillImage" and adding this field to the PolylineOptions in a new .d.ts file in my project.
I'd like to contribute this to your code, but I don't know, if the way I did this is helpful or it should be done differently.
Another approach I'd like to suggest is putting this project on npm and adding an @types entry for it. But I'm not sure if that would work either, because leaflet plugins are a bit difficult to get them to work with typescript.