Fix docker arguments in CLI#231
Conversation
kozlov721
requested review from
conorsim,
klemen1999 and
tersekmatija
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 799d003b5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| @app.meta.command(group=device_commands) | ||
| @app.command(group=device_commands) |
There was a problem hiding this comment.
Registering analyze with @app.command routes modelconverter analyze ... through launcher() when users run the installed modelconverter script (the entrypoint is modelconverter.__main__:app.meta in pyproject.toml). In that path, launcher() unconditionally reads bound.arguments["target"], but analyze has no target parameter, so this now raises a KeyError before analysis starts. Cyclopts meta-app behavior requires @app.meta.command to bypass the launcher.
Useful? React with 👍 / 👎.
|
|
||
|
|
||
| @app.meta.command(group=device_commands) | ||
| @app.command(group=device_commands) |
There was a problem hiding this comment.
Switching benchmark to @app.command also sends modelconverter benchmark ... through launcher() for normal installs (again because the console script calls app.meta), so it is wrapped by docker_exec(...) instead of running directly on the host. That defeats the change’s stated goal of running device commands outside Docker and can break benchmark/device access workflows that require host ADB/SSH visibility.
Useful? React with 👍 / 👎.
klemen1999
left a comment
klemen1999
left a comment
There was a problem hiding this comment.
Check out Codex comments ^
2 participants
Purpose
Run
benchmarkandanalyzecommands outside of a docker container.Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO