Skip to content

Upgraded DeviceMonitor#220

Open
kozlov721 wants to merge 69 commits into
mainfrom
feat/general-device-monitor
Open

Upgraded DeviceMonitor#220
kozlov721 wants to merge 69 commits into
mainfrom
feat/general-device-monitor

Conversation

@kozlov721
Copy link
Copy Markdown
Collaborator

@kozlov721 kozlov721 commented Apr 23, 2026

Purpose

Allows to monitor more metrics

Specification

  • Added RAM and CPU monitoring
  • Temperature monitoring
  • DSP frequencies instead of just the overall utilization
  • Merged all the monitors into a single DeviceMonitor

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@kozlov721 kozlov721 requested a review from a team as a code owner April 23, 2026 02:51
@kozlov721 kozlov721 requested review from conorsim, klemen1999 and tersekmatija and removed request for a team April 23, 2026 02:51
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd6d40b5e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modelconverter/utils/device_monitors.py Outdated
@kozlov721 kozlov721 force-pushed the feat/general-device-monitor branch from b35ad9b to f67af7c Compare April 23, 2026 09:39
@klemen1999 klemen1999 requested a review from ptoupas April 23, 2026 11:15
@kozlov721 kozlov721 force-pushed the feat/general-device-monitor branch from 9f3effe to 49e63ca Compare April 23, 2026 11:46
Copy link
Copy Markdown
Contributor

@ptoupas ptoupas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple extra comments on top of the on-code comments I provided:

  1. Setting just the --device-id ... flag on a benchmark run (e.g. modelconverter benchmark rvc4 --model-path luxonis/yolov8-nano-pose-estimation:coco-512x288 --power-benchmark --dsp-benchmark --device-id da79b2bf) throws the following warning: WARNING No device ID specified, using the first connected device: bb81a24e. which shouldn't be an issue given that we are providing the exact device-id. On the other hand if just the --device-ip is provided the --device-id is inferred and found properly
  2. It seems like if any of the --power-benchmark, --dsp-benchmark flags are provided in CLI the other one is also enabled by default. Even if I explicitly set the other one to --no-... the respective metric is tracked while it shouldn't. For example the following flags track both power and dsp --power-benchmark --no-dsp-benchmark. Same if I just set one like --power-benchmark or --dsp-benchmark both are tracked while it shouldn't.

Comment thread modelconverter/packages/base_benchmark.py Outdated
Comment thread modelconverter/packages/rvc4/benchmark.py Outdated
Comment thread modelconverter/utils/device_monitors.py Outdated
Comment thread modelconverter/utils/device_monitors.py Outdated
Comment thread modelconverter/utils/device_monitors.py Outdated
@kozlov721 kozlov721 force-pushed the feat/general-device-monitor branch from b1a6125 to 6e5b886 Compare May 13, 2026 18:07
@kozlov721 kozlov721 changed the base branch from fix/rvc4-types to feat/benchmark-simplify May 14, 2026 20:14
Base automatically changed from feat/benchmark-simplify to fix/rvc4-types May 15, 2026 10:59
Base automatically changed from fix/rvc4-types to main May 15, 2026 11:17
@kozlov721 kozlov721 force-pushed the feat/general-device-monitor branch from 9acd486 to c9e59b5 Compare May 15, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants