Upgraded DeviceMonitor#220
Open
kozlov721 wants to merge 69 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd6d40b5e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b35ad9b to
f67af7c
Compare
9f3effe to
49e63ca
Compare
ptoupas
reviewed
Apr 24, 2026
Contributor
ptoupas
left a comment
There was a problem hiding this comment.
A couple extra comments on top of the on-code comments I provided:
- Setting just the
--device-id ...flag on a benchmark run (e.g.modelconverter benchmark rvc4 --model-path luxonis/yolov8-nano-pose-estimation:coco-512x288 --power-benchmark --dsp-benchmark --device-id da79b2bf) throws the following warning:WARNING No device ID specified, using the first connected device: bb81a24e.which shouldn't be an issue given that we are providing the exact device-id. On the other hand if just the--device-ipis provided the--device-idis inferred and found properly - It seems like if any of the
--power-benchmark,--dsp-benchmarkflags are provided in CLI the other one is also enabled by default. Even if I explicitly set the other one to--no-...the respective metric is tracked while it shouldn't. For example the following flags track both power and dsp--power-benchmark --no-dsp-benchmark. Same if I just set one like--power-benchmarkor--dsp-benchmarkboth are tracked while it shouldn't.
…lconverter into feat/general-device-monitor
b1a6125 to
6e5b886
Compare
9acd486 to
c9e59b5
Compare
klemen1999
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allows to monitor more metrics
Specification
DeviceMonitorDependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable