Clear debug flags only when reading new debug flags #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes TIM to retain debug flags from cycle to cycle, so that debug information remains visible as long as `debug=` options are present in the custom data of the block. Before this change, debug flags were only in effect for the specific cycle where `ProcessScriptArgs` ran - the first cycle after any change to the block's custom data, and on script compilation, and on world load. After that, they reset to the default, and debug information would not display. After this change, the debug state is "sticky," and only changes when the custom data changes or the script is reloaded. It no longer resets every tick, and debug information remains available from cycle to cycle. This does _not_ preserve actual debug messages - only the set of flags indicating what debug messages to capture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes TIM to retain debug flags from cycle to cycle, so that debug information remains visible as long as
debug=options are present in the custom data of the block.Before this change, debug flags were only in effect for the specific cycle where
ProcessScriptArgsran - the first cycle after any change to the block's custom data, and on script compilation, and on world load. After that, they reset to the default, and debug information would not display.After this change, the debug state is "sticky," and only changes when the custom data changes or the script is reloaded. It no longer resets every tick, and debug information remains available from cycle to cycle.
This does not preserve actual debug messages - only the set of flags indicating what debug messages to capture.