Add ProductStatus enum for type-safe product status handling#2
Closed
kuba-wizcode wants to merge 1 commit intolunarphp:1.xfrom
Closed
Add ProductStatus enum for type-safe product status handling#2kuba-wizcode wants to merge 1 commit intolunarphp:1.xfrom
kuba-wizcode wants to merge 1 commit intolunarphp:1.xfrom
Conversation
Introduces `Lunar\Enums\ProductStatus` backed enum with `Published` and `Draft` cases, replacing hardcoded status strings throughout the codebase. Changes: - Add `Lunar\Enums\ProductStatus` enum - Cast `Product::$status` to the enum - Update `scopeStatus()` to accept both enum and string (backwards compatible) - Update `ProductFactory` to use enum Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thank you for your pull request. However, you have submitted this PR on the Lunar Core Repo which is a read-only sub split of |
|
This is coming in v2, so we won't be accepting this PR for v1, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
Lunar\Enums\ProductStatusbacked enum withPublishedandDraftcases, replacing hardcoded status strings throughout the codebase.Changes:
Lunar\Enums\ProductStatusenumProduct::$statusto the enumscopeStatus()to accept both enum and string (backwards compatible)ProductFactoryto use enum