fix: Fix dropdown panel hidden behind sibling trigger buttons#901
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a visual layering issue where the lukso-dropdown panel could render behind adjacent (sibling) trigger buttons by making the dropdown host a positioned element, and adds a Storybook reproduction to verify the behavior.
Changes:
- Update
lukso-dropdownhost styles to includeposition: relativeso the component participates correctly in stacking/paint order relative to sibling buttons. - Add a
StackingContextStorybook story with two vertically stacked trigger+dropdown rows to reproduce and validate the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/lukso-dropdown/style.css | Makes the dropdown host positioned to prevent the panel being painted under sibling triggers. |
| src/components/lukso-dropdown/lukso-dropdown.stories.ts | Adds a dedicated Storybook scenario to reproduce and confirm correct overlay behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Storybook deployed with Cloudflare Pages ☁️ 📖 🚀Storybook
Built from commit 12cb510 |
JeneaVranceanu
approved these changes
May 28, 2026
…rigger-id; add overflowX to scroll container detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ID
DEV-16284
Description
position: relative; height: 0to:host— creates a stacking context so thez-50dropdown panel floats above sibling trigger buttons;height: 0makes:hosta zero-height containing block so transform-based positioning anchors correctlybottom-7/bottom-12Tailwind classes (fixed pixel offsets that broke with PR feat: Replace openTop/isRight booleans with position prop on dropdown #898's auto-detection) withtranslateY(calc(-100% - triggerHeight - gap))inline style — works for any trigger size; falls back topreviousElementSiblingwhen notrigger-idis provided (e.g.lukso-time-picker)autoposition detection: replace viewport midpoint check with available-space comparison (boundary.bottom - rect.bottom < rect.top - boundary.top)_findScrollContainerto detect the nearest non-full-page scroll container and use its bounds for flip detection — fixesAutoPositionScrollstory and cases where the dropdown is inside a constrained scroll area; includesoverflow,overflowX, andoverflowYdetectionStackingContextStorybook story with two vertically-stacked trigger+dropdown rows to reproduce and verify the sibling overlap fix