Add localization key to placeholder#19
Open
Muhammadbarznji wants to merge 1 commit intolukeredpath:mainfrom
Open
Add localization key to placeholder#19Muhammadbarznji wants to merge 1 commit intolukeredpath:mainfrom
Muhammadbarznji wants to merge 1 commit intolukeredpath:mainfrom
Conversation
Author
|
Hi @lukeredpath , |
Owner
|
@Muhammadbarznji thanks for the PR - I will take a look. Don't worry about the CodeClimate step. |
Author
|
Hi @lukeredpath, any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds additional snapshot tests for the
ResponsiveTextFieldcomponent and includes tests for Arabic localization. These changes address issue #11 and enhance our test coverage by ensuring the component behaves correctly under various configurations and locales.Changes
Tests Added
testTextFieldInArabic: Checks the text field in the Arabic locale, both empty and with text.testTextFieldWithDifferentConfigurations: Checks the text field with different configurations (empty, no autocorrect, no autocapitalization).Related Issue
This PR addresses issue #11.
Screenshots
swift-responsive-textfield.mp4
Checklist
ResponsiveTextField.Please review the changes and provide feedback. Thank you!